-
Notifications
You must be signed in to change notification settings - Fork 13.5k
feat(input): add styles for ionic theme for fill=solid #30417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- move input.outline.scss to input.ionic.scss; - add fill solid to states page;
- add tests for ionic solid input;
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just a few requested changes on where styles are applied!
- specify attributes by classes type;
…for border-radius;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good to me! Great work 🚀
Issue number: Internal
What is the new behavior?
Does this introduce a breaking change?
Other information