Skip to content

feat(input): add styles for ionic theme for fill=solid #30417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 23, 2025

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented May 19, 2025

Issue number: Internal


What is the new behavior?

  • add fill solid to ionic theme input;
  • move input.outline.scss to input.ionic.scss;
  • add fill solid to states page;
  • remove highlight styles for ionic theme;
  • add tests for ionic solid input;

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented May 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 5:14pm

@github-actions github-actions bot added the package: core @ionic/core package label May 19, 2025
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a few requested changes on where styles are applied!

- specify attributes by classes type;
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me! Great work 🚀

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 8b5215f into next May 23, 2025
48 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-11889 branch May 23, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants